[webkit-reviews] review granted: [Bug 67750] Create a delegate class to help cleanly isolate the chromium compositor API : [Attachment 107198] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 13 18:24:29 PDT 2011

James Robinson <jamesr at chromium.org> has granted Antoine Labour
<piman at chromium.org>'s request for review:
Bug 67750: Create a delegate class to help cleanly isolate the chromium
compositor API

Attachment 107198: Patch

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107198&action=review


> Source/WebCore/platform/graphics/chromium/ContentLayerChromium.h:48
> +    static PassRefPtr<ContentLayerChromium> create(CCLayerDelegate* = 0);

nit: we're inconsistent in the various *LayerChromium::create() calls about
whether there's a default param. I don't think a null delegate makes sense for
this layer type so probably better to remove it.

> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:56
> +#include "RenderLayerBacking.h"

i don't think you need this #include any more, and it's actually a layering
violation (things in WebCore/platform should not depend on anything in WebCore/
outside of WebCore/platform)

> Source/WebCore/platform/graphics/chromium/ImageLayerChromium.h:52
> +    static PassRefPtr<ImageLayerChromium> create(CCLayerDelegate* = 0);

nit: no default 0

> Source/WebCore/platform/graphics/chromium/ImageLayerChromium.h:61
> +    ImageLayerChromium(CCLayerDelegate*);

nit: explicit

More information about the webkit-reviews mailing list