[webkit-reviews] review granted: [Bug 67727] Make JSCell::toBoolean non-virtual : [Attachment 107264] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 13 17:26:11 PDT 2011

Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 67727: Make JSCell::toBoolean non-virtual

Attachment 107264: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107264&action=review

> Source/JavaScriptCore/ChangeLog:11
> +	   Its descendents in JSObject and JSString have also been made
non-virtual.  JSValue now
> +	   explicitly covers all cases of toBoolean, so having a virtual
implementation of 

Typo: descendants

This should say JSCell, not JSValue.

More information about the webkit-reviews mailing list