[webkit-reviews] review granted: [Bug 63351] webkit-patch should be able to find users and add them to bugzilla groups : [Attachment 98536] Fix one exception

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 63351: webkit-patch should be able to find users and add them to bugzilla
groups
https://bugs.webkit.org/show_bug.cgi?id=63351

Attachment 98536: Fix one exception
https://bugs.webkit.org/attachment.cgi?id=98536&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98536&action=review

> Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:54
> +	   self._group_name_to_group_string_cache = {}

Should this use a memoized function instead?

> Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:71
> +	   soup = BeautifulSoup(results_page,
convertEntities=BeautifulStoneSoup.HTML_ENTITIES)

There's no XML version of this page?

> Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:268
> +	   self.edit_user_parser = EditUsersParser()

Do we want this to be persistent or instantiated each time?  Maybe it doen't
matter since the process isn't long-lived.

> Tools/Scripts/webkitpy/tool/commands/__init__.py:8
> +from webkitpy.tool.commands.adduserstogroups import AddUsersToGroups
>  from webkitpy.tool.commands.bugsearch import BugSearch
>  from webkitpy.tool.commands.bugfortest import BugForTest
>  from webkitpy.tool.commands.download import *
>  from webkitpy.tool.commands.earlywarningsystem import *
> +from webkitpy.tool.commands.findusers import *

Not really related to this patch, but we should clean up whether this file
always uses *, etc.