[webkit-reviews] review granted: [Bug 67985] SpeculativeJIT::shouldSpeculateInteger(NodeIndex, NodeIndex) should return false if either node can be double : [Attachment 107234] the patch - fix review, and hardened shouldSpeculateInteger() even more
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 13 17:01:48 PDT 2011
Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 67985: SpeculativeJIT::shouldSpeculateInteger(NodeIndex, NodeIndex) should
return false if either node can be double
https://bugs.webkit.org/show_bug.cgi?id=67985
Attachment 107234: the patch - fix review, and hardened
shouldSpeculateInteger() even more
https://bugs.webkit.org/attachment.cgi?id=107234&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107234&action=review
r=me but please remove stray printfs.
> Source/JavaScriptCore/ChangeLog:9
> + This is a 17% speed-up on 3b-cube.
Typo: "3b".
> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:390
> + printf("%d is a double constant.\n", nodeIndex);
Stray printf.
> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:400
> + printf("%d produces a double.\n", nodeIndex);
And here.
> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:405
> + printf("%d has a double prediction.\n", nodeIndex);
And here.
More information about the webkit-reviews
mailing list