[webkit-reviews] review denied: [Bug 28633] Submitting a form with target=_blank works only once : [Attachment 107248] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 13 16:43:23 PDT 2011

Andy Estes <aestes at apple.com> has denied Jon Lee <jonlee at apple.com>'s request
for review:
Bug 28633: Submitting a form with target=_blank works only once

Attachment 107248: Patch

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107248&action=review

I'm going to r- this because of the setTimeout() issue.

> LayoutTests/fast/forms/submit-to-blank-multiple-times.html:68
> +	       setTimeout(checkForFlag, 500);

The 500ms timeout is unfortunate. Did you try this with a 0ms timeout?

> LayoutTests/fast/forms/submit-to-blank-multiple-times.html:79
> +	       setTimeout(checkForFlag, 500);

Same question as above. It looks like this test will take at least 2 seconds to
run with each of these timers being called twice. This seems unnecessarily

> Source/WebCore/page/mac/EventHandlerMac.mm:-481
> -    m_frame->loader()->resetMultipleFormSubmissionProtection();

Are there other ports where this call can be removed now that it is in a common

More information about the webkit-reviews mailing list