[webkit-reviews] review granted: [Bug 67692] Unzip initialization lists and constructors in JSCell hierarchy (6/7) : [Attachment 107121] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 13 16:27:02 PDT 2011

Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 67692: Unzip initialization lists and constructors in JSCell hierarchy

Attachment 107121: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107121&action=review

review+ assuming you do the run-bindings-tests thing I requested

>> Source/JavaScriptCore/ChangeLog:20
>> +	    File names truncated for brevity. 
> Need more details on why this is done.

Please do not do that. We do want you to include the filenames and in most
cases, the function names too.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:733
> +	   push(@headerContent, "	 $className* ptr = new
(JSC::allocateCell<$className>(globalData.heap)) ${className}(globalData,
structure, impl, windowShell);\n");

Since you are changing the code generator, you need to run "run-bindings-tests
--reset-results" and check in the changes to the output of the bindings code
generation tests.

More information about the webkit-reviews mailing list