[webkit-reviews] review denied: [Bug 68033] Implement globalFlag for WebKitTestRunner : [Attachment 107247] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 13 16:19:56 PDT 2011

Darin Adler <darin at apple.com> has denied Jon Lee <jonlee at apple.com>'s request
for review:
Bug 68033: Implement globalFlag for WebKitTestRunner

Attachment 107247: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107247&action=review

This is OK. But it would be best to also include the patches that can be
removed from the Skipped list.

> Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h:205
> +    bool m_globalFlag;

Need to initialize m_globalFlag in the constructor instead of letting it have a
random uninitialized value at first. Also probably need to reset it in between

More information about the webkit-reviews mailing list