[webkit-reviews] review granted: [Bug 67727] Remove toBoolean from JSCell : [Attachment 107214] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 13 13:32:03 PDT 2011


Geoffrey Garen <ggaren at apple.com> has granted  review:
Bug 67727: Remove toBoolean from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67727

Attachment 107214: Patch
https://bugs.webkit.org/attachment.cgi?id=107214&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107214&action=review


Code looks good, but please update the ChangeLog to be congruent with the final
patch you and Darin came up with here.

> Source/JavaScriptCore/ChangeLog:8
> +	   JSCell::toBoolean has been removed and its descendents in JSObject
and JSString

Not true anymore! :)


More information about the webkit-reviews mailing list