[webkit-reviews] review granted: [Bug 68018] Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5 : [Attachment 107207] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 68018: Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
https://bugs.webkit.org/show_bug.cgi?id=68018

Attachment 107207: Patch
https://bugs.webkit.org/attachment.cgi?id=107207&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107207&action=review


> Source/WebKit2/Configurations/FeatureDefines.xcconfig:102
> +FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS)
$(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING)
$(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_CSS3_FLEXBOX) $(ENABLE_DATABASE)
$(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS)
$(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE)
$(ENABLE_EVENTSOURCE) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS)
$(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE)
$(ENABLE_INDEXED_DATABASE) $(ENAwarning: LF will be replaced by CRLF in
WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops.

What's up with "warning: LF will be replaced by CRLF in
WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops."?