[webkit-reviews] review denied: [Bug 61743] [Qt] LayoutTests/fast/canvas/webgl/renderbuffer-initialization.html fails for Qt based webkit : [Attachment 97335] Patch for the fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 13 10:50:00 PDT 2011


Kenneth Russell <kbr at google.com> has denied Idrees <sidreesshah at hotmail.com>'s
request for review:
Bug 61743: [Qt] LayoutTests/fast/canvas/webgl/renderbuffer-initialization.html
fails for Qt based webkit
https://bugs.webkit.org/show_bug.cgi?id=61743

Attachment 97335: Patch for the fix.
https://bugs.webkit.org/attachment.cgi?id=97335&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
This patch is out of date. GraphicsContext3DInternal was renamed to
GraphicsContext3DPrivate in https://bugs.webkit.org/show_bug.cgi?id=67172 .
Further, if the Qt port uses GraphicsContext3DOpenGL.cpp at all, then it should
be able to share the implementation of GraphicsContext3D::reshape in that file.
Please both update the patch and try to reuse this code.


More information about the webkit-reviews mailing list