[webkit-reviews] review granted: [Bug 67985] SpeculativeJIT::shouldSpeculateInteger(NodeIndex, NodeIndex) should return false if either node can be double : [Attachment 107146] the patch - disable tiering
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 13 09:53:06 PDT 2011
Darin Adler <darin at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 67985: SpeculativeJIT::shouldSpeculateInteger(NodeIndex, NodeIndex) should
return false if either node can be double
https://bugs.webkit.org/show_bug.cgi?id=67985
Attachment 107146: the patch - disable tiering
https://bugs.webkit.org/attachment.cgi?id=107146&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107146&action=review
> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:385
> + bool shouldNotSpeculateInteger(NodeIndex nodeIndex)
I think the function would be clearer with a small “why” comment in it.
> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:392
> + if ((info.registerFormat() | DataFormatJS) == DataFormatJSDouble
> + || (info.spillFormat() | DataFormatJS) == DataFormatJSDouble)
I think this would read better on a single line.
I think this would read better with a small inline helper function that does
the (format | DataFormatJS) == DataFormatJSDouble ditty, with a pleasant name.
More information about the webkit-reviews
mailing list