[webkit-reviews] review granted: [Bug 65025] Eliminate WebKit2 compilation warnings. : [Attachment 107168] more compiler warnings fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wajahat Siddiqui
<mdwajahatali.siddiqui at motorola.com>'s request for review:
Bug 65025: Eliminate WebKit2 compilation warnings.
https://bugs.webkit.org/show_bug.cgi?id=65025

Attachment 107168: more compiler warnings fix
https://bugs.webkit.org/attachment.cgi?id=107168&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107168&action=review


> Source/WebKit2/UIProcess/WebContext.cpp:324
> +	   String sampleLogFilePath = String::format("WebProcess%llu",
static_cast<long long unsigned int>(now));

The name we use for this type in WebKit is "unsigned long long" rather than
"long long unsigned int". Anders may have additional comments. I know he often
uses uint64_t intentionally so we might instead want to use the string that
lets us format a uint64_t instead of changing the typecast.

> Source/WebKit2/UIProcess/WebContext.cpp:733
> +    String sampleLogFilePath = String::format("WebProcess%llu",
static_cast<long long unsigned int>(now));

Ditto.

> Source/WebKit2/ChangeLog:3
> +	   Eliminate WebKit2 compilation warnings.

It would be better if this said what compiler and platform these warnings were
found with.