[webkit-reviews] review granted: [Bug 66856] [EFL] Do not always return the cached frame name. : [Attachment 107181] Use operator== instead of strcmp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 13 09:46:14 PDT 2011


Antonio Gomes <tonikitoo at webkit.org> has granted Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 66856: [EFL] Do not always return the cached frame name.
https://bugs.webkit.org/show_bug.cgi?id=66856

Attachment 107181: Use operator== instead of strcmp
https://bugs.webkit.org/attachment.cgi?id=107181&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107181&action=review


> Source/WebKit/efl/ewk/ewk_frame.cpp:357
> +    const WTF::String frameName = sd->frame->tree()->uniqueName();

nit: const here seem unusual.

> Source/WebKit/efl/ewk/ewk_frame.cpp:359
> +    if ((sd->name) && (sd->name == frameName))

nit: extra ()'s


More information about the webkit-reviews mailing list