[webkit-reviews] review denied: [Bug 66969] Chromium: Add a layer for rubber-band overhang painting to the hardware path. : [Attachment 106764] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied asvitkine at chromium.org's
request for review:
Bug 66969: Chromium: Add a layer for rubber-band overhang painting to the
hardware path.
https://bugs.webkit.org/show_bug.cgi?id=66969

Attachment 106764: Patch
https://bugs.webkit.org/attachment.cgi?id=106764&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106764&action=review


> Source/WebCore/rendering/RenderLayerCompositor.cpp:960
> +	   // Keep the overhang layer's size synchronized with the frame size.

This comment is useless, remove it

> Source/WebCore/rendering/RenderLayerCompositor.h:316
> +    OwnPtr<GraphicsLayer> m_layerForOverhangAreas;

shouldn't this be guarded by #if PLATFORM(CHROMIUM) along with the other logic?
There's no need to add overhead for other ports that will never use this.

>
LayoutTests/platform/chromium-gpu/compositing/rubberbanding/transform-overhang-
e-expected.txt:1
> +layer at (0,0) size 800x600

you shouldn't need any of these since the render tree is not useful.  Please
add the line "layoutTestController.dumpAsText(true)" to your tests