[webkit-reviews] review denied: [Bug 67976] Remove remnants of code that assume Lengths are 28 bit integers. : [Attachment 107119] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 13 01:48:02 PDT 2011
Eric Seidel <eric at webkit.org> has denied Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 67976: Remove remnants of code that assume Lengths are 28 bit integers.
https://bugs.webkit.org/show_bug.cgi?id=67976
Attachment 107119: Patch
https://bugs.webkit.org/attachment.cgi?id=107119&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107119&action=review
> Source/WebCore/rendering/AutoTableLayout.cpp:271
> + maxWidth = std::numeric_limits<LayoutUnit>::max();
Why is this LayoutUnit::max and the other is INT_MAX? Does Length use
LayoutUnit or int?
More information about the webkit-reviews
mailing list