[webkit-reviews] review denied: [Bug 20677] WebKit wraps between hyphen-minus and numeric characters : [Attachment 106301] new patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 20677: WebKit wraps between hyphen-minus and numeric characters
https://bugs.webkit.org/show_bug.cgi?id=20677

Attachment 106301: new patch
https://bugs.webkit.org/attachment.cgi?id=106301&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106301&action=review


> Source/WebCore/rendering/break_lines.cpp:134
> +	       // while allow breaking in 'ABCD-1234' and '1234-5678'.
<https://bugs.webkit.org/show_bug.cgi?id=20677>

I don’t think having the bug number here is a good idea. I see other bug URLs
in this file, but there’s no need long-term to track the bug number of each bug
we fixed.

> LayoutTests/ChangeLog:12
> +	   * fast/text/line-breaks-after-hyphen-before-number.html: Added.

I can’t find this test case in the patch.

> LayoutTests/fast/text/line-breaks-after-hyphen-before-number-expected.txt:8
> +0: PASS
> +1: PASS
> +2: PASS
> +3: PASS
> +4: PASS
> +5: PASS
> +Summary: PASS

This output is not clear at all. The test would be better if the output made it
clearer what was being tested.