[webkit-reviews] review denied: [Bug 63615] Allow notification origin permission request when no js callback is provided : [Attachment 99448] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Alexandre Mazari <scaroo at gmail.com>'s
request for review:
Bug 63615: Allow notification origin permission request when no js callback is
provided
https://bugs.webkit.org/show_bug.cgi?id=63615

Attachment 99448: Patch
https://bugs.webkit.org/attachment.cgi?id=99448&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99448&action=review

We need a test.

> Source/WebCore/bindings/js/JSDesktopNotificationsCustom.cpp:63
> +	   RefPtr<JSCustomVoidCallback> callback =
JSCustomVoidCallback::create(exec->argument(0).getObject(),
toJSDOMGlobalObject(static_cast<Document*>(context), exec));

I mgiht have used a local object for the global object to make this line more
readable, but this is also OK.

> Source/WebCore/bindings/js/JSDesktopNotificationsCustom.cpp:66
> +	 impl()->requestPermission(0);

Indent.  Sad that check-webkit-style doesn't notice.