[webkit-reviews] review denied: [Bug 66876] [EFL] Add auxiliary DRT API to ewk_frame. : [Attachment 105038] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 12 15:53:52 PDT 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Raphael Kubo da
Costa <kubo at profusion.mobi>'s request for review:
Bug 66876: [EFL] Add auxiliary DRT API to ewk_frame.
https://bugs.webkit.org/show_bug.cgi?id=66876

Attachment 105038: Patch
https://bugs.webkit.org/attachment.cgi?id=105038&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105038&action=review


> Source/WebKit/efl/ChangeLog:9
> +	   In a similar fashion to r93599 and r93599, add some API calls
required
> +	   by EFL's DumpRenderTree.

Let's add these methods in a class like DumpRenderTreeSupport. Qt does
something like that. That way we can keep more of the project in C++ and follow
WebKit style.


More information about the webkit-reviews mailing list