[webkit-reviews] review denied: [Bug 66863] [EFL] Add API to call Page::findString() with all options. : [Attachment 105014] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Raphael Kubo da
Costa <kubo at profusion.mobi>'s request for review:
Bug 66863: [EFL] Add API to call Page::findString() with all options.
https://bugs.webkit.org/show_bug.cgi?id=66863

Attachment 105014: Patch
https://bugs.webkit.org/attachment.cgi?id=105014&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105014&action=review


> Source/WebKit/efl/ewk/ewk_private.h:97
> +Eina_Bool ewk_view_text_search_with_options(const Evas_Object *o, const char
*string, WebCore::FindOptions findOptions);

I really don't like this. At first it seems like an EFL api method, but then it
contains WebCore types. IF this is needed for the LTC, do a
DumpRenderTreeSupport class like Qt. That way we can also keep all this in C++