[webkit-reviews] review denied: [Bug 66856] [EFL] Do not always return the cached frame name. : [Attachment 104993] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Raphael Kubo da
Costa <kubo at profusion.mobi>'s request for review:
Bug 66856: [EFL] Do not always return the cached frame name.
https://bugs.webkit.org/show_bug.cgi?id=66856

Attachment 104993: Patch
https://bugs.webkit.org/attachment.cgi?id=104993&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104993&action=review


> Source/WebKit/efl/ewk/ewk_frame.cpp:361
> +    if ((sd->name) && (!strcmp(sd->name, cs.data())))
> +	   return sd->name;

WebKit's string classes can do comparison. Please avoid using pure C methods
such as strcmp.