[webkit-reviews] review denied: [Bug 63044] [EFL] Makes themeForPage() return static RenderThemeEfl. : [Attachment 97930] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 12 15:47:42 PDT 2011

Eric Seidel <eric at webkit.org> has denied Jaehun Lim <ljaehun.lim at samsung.com>'s
request for review:
Bug 63044: [EFL] Makes themeForPage() return static RenderThemeEfl.

Attachment 97930: Proposed patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
Does the RenderTheme hold onto the Page?  If it doesn't, then it seems this
will crash.  If it does, then your'e extending the lifetime of the first page
forever (leaking it).  Both seem bad.

More information about the webkit-reviews mailing list