[webkit-reviews] review denied: [Bug 62357] Expose aria-labelledby as TitleUIElement? : [Attachment 96685] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 12 15:35:43 PDT 2011

Eric Seidel <eric at webkit.org> has denied Alice Boxhall
<aboxhall at chromium.org>'s request for review:
Bug 62357: Expose aria-labelledby as TitleUIElement?

Attachment 96685: Patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96685&action=review

This patch is clearly not ready for review.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

This will cause the CQ to fail.  You should either replace this with a list of
affected tests, or explain why testing is impossible/impractical.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1356
> +//	 const AtomicString& ariaLabelledBy = ariaLabeledByAttribute();
> +//	 if (!ariaLabelledBy.isEmpty())
> +//	     return ariaLabelledBy;

We don't commit commented out code.

> Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm:1032
> +    else if (m_object->isWebArea()) {
>	   objectAttributes = webAreaAttrs;
> +    }


More information about the webkit-reviews mailing list