[webkit-reviews] review granted: [Bug 67522] REGRESSION: Moving up doesn't work in some cases : [Attachment 107089] fixes the bug

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 67522: REGRESSION: Moving up doesn't work in some cases
https://bugs.webkit.org/show_bug.cgi?id=67522

Attachment 107089: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=107089&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107089&action=review


> Source/WebCore/editing/visible_units.cpp:536
> +	       Position pos = n->hasTagName(brTag) ? positionBeforeNode(n) :
createLegacyEditingPosition(n, caretMaxOffset(n));

Should this be a helper inline?  Is this concept needed elsewhere?