[webkit-reviews] review granted: [Bug 57537] Setting document.title doesn't affect contents of title tag of XHTML documents : [Attachment 107078] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jacky Jiang
<zkjiang008 at gmail.com>'s request for review:
Bug 57537: Setting document.title doesn't affect contents of title tag of XHTML
documents
https://bugs.webkit.org/show_bug.cgi?id=57537

Attachment 107078: Patch
https://bugs.webkit.org/attachment.cgi?id=107078&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107078&action=review


Looks good, thank you!

As Darin said, there can be a lot of interesting finds around other places that
call isHTMLDocument().

> LayoutTests/fast/dom/title-content-set-innerText-get.xhtml:12
> +<p id="description"></p>
> +<div id="console"></div> 
> +<script>
> +description("This test ensures that we can update the contents of the title
tag of the XHTML document when setting document.title");

This is how it's done it the test I gave a link to, but there is really no
reason to set the description via a JavaScript function - one can just put it
directly in a <p> element.