[webkit-reviews] review granted: [Bug 67440] [chromium] Move contents texture manager from LayerRendererChromium to CCLayerTreeHost : [Attachment 107072] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 12 12:13:43 PDT 2011


Kenneth Russell <kbr at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 67440: [chromium] Move contents texture manager from LayerRendererChromium
to CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=67440

Attachment 107072: Patch
https://bugs.webkit.org/attachment.cgi?id=107072&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107072&action=review


After cursory look seems good to me; nice test case. rs=me

> Source/WebCore/platform/graphics/chromium/cc/CCCanvasLayerImpl.h:55
> +    virtual const char* layerTypeAsString() const { return "CanvasLayer"; }

Can we move the definition of virtuals into the .cpp file? Here and elsewhere.


More information about the webkit-reviews mailing list