[webkit-reviews] review granted: [Bug 67918] Crashes in WebCore::InsertListCommand::unlistifyParagraph : [Attachment 107030] Patch

Mon Sep 12 09:05:02 PDT 2011

Ryosuke Niwa <rniwa at webkit.org> has granted Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 67918: Crashes in WebCore::InsertListCommand::unlistifyParagraph
https://bugs.webkit.org/show_bug.cgi?id=67918

Attachment 107030: Patch
https://bugs.webkit.org/attachment.cgi?id=107030&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107030&action=review

> LayoutTests/editing/execCommand/insert-list-in-noneditable-list-parent.html:1

> +<script src="../../resources/dump-as-markup.js"></script>

Can we have <!DOCTYPE  html>? or would that break the test?

> Source/WebCore/ChangeLog:8
> +	   execCommand("InsertUnorderedList") was crashing if the parent node
of the target is a kind of list element and it is not contenteditable.

Nit: This line seems too long.