[webkit-reviews] review granted: [Bug 67932] Web Inspector: event dividers do not update timeline boundaries. : [Attachment 107048] Patch

[bugzilla-daemon at webkit.org]

Tony Gentilcore <tonyg at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 67932: Web Inspector: event dividers do not update timeline boundaries.
https://bugs.webkit.org/show_bug.cgi?id=67932

Attachment 107048: Patch
https://bugs.webkit.org/attachment.cgi?id=107048&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107048&action=review


> Source/WebCore/inspector/front-end/NetworkPanel.js:630
> +	   // Schedule refresh to update boundaries and draw the new line.

Up to you, but both of these comments seem a bit gratuitous. They don't convey
much more info than the method name.

> Source/WebCore/inspector/front-end/NetworkPanel.js:667
> +	       boundariesChanged =
this.calculator.updateBoundariesForEventTime(this._mainResourceDOMContentTime)
|| boundariesChanged;

Cleaner to use |= for these two, right?