[webkit-reviews] review denied: [Bug 67928] [Qt] Build fails after r94920 with strict compiler : [Attachment 107036] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 12 05:00:13 PDT 2011
Caio Marcelo de Oliveira Filho <cmarcelo at webkit.org> has denied Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 67928: [Qt] Build fails after r94920 with strict compiler
https://bugs.webkit.org/show_bug.cgi?id=67928
Attachment 107036: proposed fix
https://bugs.webkit.org/attachment.cgi?id=107036&action=review
------- Additional Comments from Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107036&action=review
Ops. Doesn't LGTM yet :P
> Source/JavaScriptCore/wtf/RedBlackTree.h:-196
> - Node* newSubTreeRoot =
rightRotate(x->parent()->parent());
You need to keep this rightRotate, just ignore the return value.
> Source/JavaScriptCore/wtf/RedBlackTree.h:-218
> - Node* newSubTreeRoot =
leftRotate(x->parent()->parent());
You need to keep this leftRotate, just ignore the return value.
More information about the webkit-reviews
mailing list