[webkit-reviews] review denied: [Bug 67918] Crashes in WebCore::InsertListCommand::unlistifyParagraph : [Attachment 107021] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 67918: Crashes in WebCore::InsertListCommand::unlistifyParagraph
https://bugs.webkit.org/show_bug.cgi?id=67918

Attachment 107021: Patch
https://bugs.webkit.org/attachment.cgi?id=107021&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107021&action=review


> Source/WebCore/editing/htmlediting.cpp:669
> -	   if (n->hasTagName(liTag) || isListElement(n->parentNode()))
> +	   if (n->hasTagName(liTag) || (isListElement(n->parentNode()) &&
n->parentNode()->rendererIsEditable()))

This change seems wrong. You should be checking that n != root instead.