[webkit-reviews] review denied: [Bug 67918] Crashes in WebCore::InsertListCommand::unlistifyParagraph : [Attachment 107021] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 11 22:50:52 PDT 2011

Ryosuke Niwa <rniwa at webkit.org> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 67918: Crashes in WebCore::InsertListCommand::unlistifyParagraph

Attachment 107021: Patch

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107021&action=review

> Source/WebCore/editing/htmlediting.cpp:669
> -	   if (n->hasTagName(liTag) || isListElement(n->parentNode()))
> +	   if (n->hasTagName(liTag) || (isListElement(n->parentNode()) &&

This change seems wrong. You should be checking that n != root instead.

More information about the webkit-reviews mailing list