[webkit-reviews] review granted: [Bug 60430] selectstart is not fired when selection was created by arrow keys : [Attachment 106853] Updated patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Arko Saha <nghq36 at motorola.com>'s
request for review:
Bug 60430: selectstart is not fired when selection was created by arrow keys
https://bugs.webkit.org/show_bug.cgi?id=60430

Attachment 106853: Updated patch
https://bugs.webkit.org/attachment.cgi?id=106853&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106853&action=review


> Source/WebCore/ChangeLog:1
> +2011-09-09  Arko Saha  <arko at motorola.com> and Kaustubh Atrawalkar 
<kaustubh at motorola.com>

We don't normally list two authors like this. If you're like to live a credit,
then please mention it in the description below (after/before "Fire selectstart
when...").

> LayoutTests/fast/events/selectstart-by-arrow-keys-prevent-default.html:17
> +eventSender.keyDown("rightArrow", ["shiftKey"]);

Because this line will throw an exception outside of DRT, you should consider
wrapping it in if and explain how you'd test manually on a browser.

> LayoutTests/fast/events/selectstart-by-arrow-keys.html:19
> +eventSender.keyDown("rightArrow");
> +logResult('Check (Right arrow)', 0);

Ditto about wrapping these in if and explaining how to test manually. If manual
test is not possible, you can also say so to clarify.