[webkit-reviews] review granted: [Bug 67727] Remove toBoolean from JSCell : [Attachment 106948] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 11 14:45:25 PDT 2011


Oliver Hunt <oliver at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 67727: Remove toBoolean from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67727

Attachment 106948: Patch
https://bugs.webkit.org/attachment.cgi?id=106948&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106948&action=review


r=me, assuming you fix the windows exports

> Source/JavaScriptCore/runtime/JSString.h:698
>  

In response to sam's comment: JSValue::toBoolean was already inline just in a
different (random) file


More information about the webkit-reviews mailing list