[webkit-reviews] review canceled: [Bug 67826] JavaScriptCore does not have speculative->baseline OSR : [Attachment 106988] the patch - once again, changed Platform.h

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has canceled Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 67826: JavaScriptCore does not have speculative->baseline OSR
https://bugs.webkit.org/show_bug.cgi?id=67826

Attachment 106988: the patch - once again, changed Platform.h
https://bugs.webkit.org/attachment.cgi?id=106988&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
This now passes tests with tiering turned both on and off.  It's lucky that
tiering turned off still leads to the OSR exit analysis running, since it
revealed breakeage in an ASSERT statement for SetLocals.  It turns out that
synthetic SetLocals (like the ones that initialize variables to undefined) are
sufficiently special that the ASSERT about the bytecode index of the node
following the SetLocal was wrong.  The ASSERT just needed to be made a slight
bit more lenient.