[webkit-reviews] review granted: [Bug 67882] Remove DocumentWriter::deprecatedFrameEncoding() : [Attachment 106969] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 67882: Remove DocumentWriter::deprecatedFrameEncoding()
https://bugs.webkit.org/show_bug.cgi?id=67882

Attachment 106969: Patch
https://bugs.webkit.org/attachment.cgi?id=106969&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106969&action=review


There is nothing contentious about this change.  This code is only used on the
MAC and WIN ports and after investigations this evening is believed to be
wrong, but isolating it to those ports for now will at least stop us from
crashing here on other ports.

> Source/WebCore/loader/FrameLoader.cpp:2549
> +    // For a newly opened frame with an empty URL, encoding() should not be

You mean document->encoding(), no?