[webkit-reviews] review denied: [Bug 67882] Remove DocumentWriter::deprecatedFrameEncoding() by implementing RFC 6266 : [Attachment 106959] Updated to apply to tip of tree

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 67882: Remove DocumentWriter::deprecatedFrameEncoding() by implementing RFC
6266
https://bugs.webkit.org/show_bug.cgi?id=67882

Attachment 106959: Updated to apply to tip of tree
https://bugs.webkit.org/attachment.cgi?id=106959&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
The attached patch doesn't implement any new encoding scheme, it only removes
existing support for non-ASCII file names. So, it will break downloading files
with non-ASCII names from Web sites. That's of course unacceptable.

There is more processing going on before Foundation puts a suggested file name
into NSURLResponse, so new encoding schemes for Content-Disposition cannot be
implemented in WebKit.

We'll need to pass suggested encoding to network layer in foreseeable future
(perhaps as long as there remains a user visible concept of "file"), so what we
need is to give deprecatedFrameEncoding a better name, and to remove comments
implying that it's going away.