[webkit-reviews] review denied: [Bug 67081] StringBuilder::toStringReserveCapacity() needs to be const : [Attachment 106709] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 9 18:58:33 PDT 2011


Darin Adler <darin at apple.com> has denied Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 67081: StringBuilder::toStringReserveCapacity() needs to be const
https://bugs.webkit.org/show_bug.cgi?id=67081

Attachment 106709: patch
https://bugs.webkit.org/attachment.cgi?id=106709&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I’m going to say review-. The change to StringBuilder is fine. But all the
changes to adopt StringBuilder need to be reviewed individually or in smaller
groups that have similar issues, rather than in one large patch.


More information about the webkit-reviews mailing list