[webkit-reviews] review granted: [Bug 67171] requestAnimationFrame doesn't throttle on Mac : [Attachment 106949] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 9 18:42:43 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 67171: requestAnimationFrame doesn't throttle on Mac
https://bugs.webkit.org/show_bug.cgi?id=67171

Attachment 106949: Patch
https://bugs.webkit.org/attachment.cgi?id=106949&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106949&action=review


> Source/WebCore/dom/ScriptedAnimationController.cpp:145
> +    double scheduleDelay = max(MinimumAnimationInterval - (currentTime() -
m_lastAnimationFrameTime), 0.0);

You can use max<double> to avoid the "0.0".

> Source/WebCore/dom/ScriptedAnimationController.h:76
> +    Timer<ScriptedAnimationController> m_animationTimer;\

I don't think this compiled.


More information about the webkit-reviews mailing list