[webkit-reviews] review denied: [Bug 67832] [chromium] Add GraphicsContext3DPrivate:createGraphicsContextForAnotherThread : [Attachment 106877] now with comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 9 18:22:22 PDT 2011

Kenneth Russell <kbr at google.com> has denied Nat Duca <nduca at chromium.org>'s
request for review:
Bug 67832: [chromium] Add

Attachment 106877: now with comments.

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106877&action=review

Overall this looks good but one small thing needs cleanup before landing.

> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:122
> +PassRefPtr<GraphicsContext3D>
::WebGraphicsContext3D> webContext, GraphicsContext3D::Attributes attrs,
HostWindow* hostWindow, GraphicsContext3D::RenderStyle renderStyle, bool

WebKit style strongly discourages the use of bool arguments because they aren't
self-describing at the call site. Please define a little enum in
GraphicsContext3DPrivate.h like ThreadUsage { ForUseOnThisThread,
ForUseOnAnotherThread } and pass that instead.

More information about the webkit-reviews mailing list