[webkit-reviews] review denied: [Bug 67848] [chromium] Workaround for String/HashSet/StringHash #include order glitch : [Attachment 106869] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 9 14:48:26 PDT 2011

Kenneth Russell <kbr at google.com> has denied Iain Merrick <husky at google.com>'s
request for review:
Bug 67848: [chromium] Workaround for String/HashSet/StringHash #include order

Attachment 106869: Patch

------- Additional Comments from Kenneth Russell <kbr at google.com>
This seems awfully suspicious because there are some files (like
Extensions3DChromium.cpp) which compile just fine and include only their
header, GraphicsContext3D.h and GraphicsContext3DPrivate.h -- and
GraphicsContext3DPrivate.h already includes GraphicsContext3D.h. Could you
please continue to investigate the underlying problem rather than committing
this workaround, which isn't necessary for the sources currently in the tree?

More information about the webkit-reviews mailing list