[webkit-reviews] review requested: [Bug 67733] [Chromium] Separate WebKit initialization and V8 initialization in chromium port : [Attachment 106896] This patch adds a parameter to WebKit::initialize instead.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 9 12:01:34 PDT 2011
Dmitry Lomov <dslomov at google.com> has asked for review:
Bug 67733: [Chromium] Separate WebKit initialization and V8 initialization in
chromium port
https://bugs.webkit.org/show_bug.cgi?id=67733
Attachment 106896: This patch adds a parameter to WebKit::initialize instead.
https://bugs.webkit.org/attachment.cgi?id=106896&action=review
------- Additional Comments from Dmitry Lomov <dslomov at google.com>
What do you think about this variant?
I have added an overload with the old signature too (that initialized V8 by
default).
This other overload is needed anyway until corresponding changes in chromium
are done. After that it can be kept or removed. I am leaning towards keeping it
and using non-default only in special cases, but then we'll have an equivalent
of a parameter with default argument, which is not good. What do you think is
the right call?
More information about the webkit-reviews
mailing list