[webkit-reviews] review denied: [Bug 67857] Provide a way to get WebArchive from a BundleFrame : [Attachment 106890] Implement WKBundleFrameCopyWebArchive()

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Ada Chan <adachan at apple.com>'s request
for review:
Bug 67857: Provide a way to get WebArchive from a BundleFrame
https://bugs.webkit.org/show_bug.cgi?id=67857

Attachment 106890: Implement WKBundleFrameCopyWebArchive()
https://bugs.webkit.org/attachment.cgi?id=106890&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106890&action=review


We are trying to get in the habit of adding tests for new API, so please add a
test in TestWebKitAPI.

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:256
> +    RetainPtr<CFDataRef> data;
> +    if (RefPtr<LegacyWebArchive> archive =
LegacyWebArchive::create(toImpl(frameRef)->coreFrame()->document())) {
> +	   if ((data = archive->rawDataRepresentation()))
> +	       return WKDataCreate(CFDataGetBytePtr(data.get()),
CFDataGetLength(data.get()));
> +    }

The code to do this should be on the WebFrame itself.  In general, we try to
keep the code in API files to a minimum, mainly casts.