[webkit-reviews] review requested: [Bug 64812] Buildbot marks a nrwt bot red when tests are missing results : [Attachment 106823] fixes this bug for good

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 64812: Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812

Attachment 106823: fixes this bug for good
https://bugs.webkit.org/attachment.cgi?id=106823&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106823&action=review


>>> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:333
>>>		 return FAILURE
>> 
>> If there are 5 new test, but 0 real failure, then result will 
>> be WARNINGS, but cmd.rc == 5 will cause return FAILURE.
> 
> count_of_new_tests = 0
>		   count_of_flakey_tests = 0

Nope. Because of recent nrwt change, nrwt no longer report missing. It always
report them as flaky.

Also, we should fix nrwt to return 0 when some tests are missing results.