[webkit-reviews] review granted: [Bug 67655] AssociatedURLLoader should check HTTP method / headers for untrusted requests. : [Attachment 106631] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Bill Budge
<bbudge at gmail.com>'s request for review:
Bug 67655: AssociatedURLLoader should check HTTP method / headers for untrusted
requests.
https://bugs.webkit.org/show_bug.cgi?id=67655

Attachment 106631: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=106631&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106631&action=review


> Source/WebKit/chromium/src/AssociatedURLLoader.cpp:56
> +namespace {

nit: put the anonymous namespace inside the WebKit namespace.  then we
shoudn't need the 'using namespace WebKit' up above.

> Source/WebKit/chromium/src/AssociatedURLLoader.cpp:289
> +	   m_clientAdapter->setDelayedError(ResourceError());

what are your plans for this?