[webkit-reviews] review denied: [Bug 64812] Buildbot marks a nrwt bot red when tests are missing results : [Attachment 106823] fixes this bug for good

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has denied Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 64812: Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812

Attachment 106823: fixes this bug for good
https://bugs.webkit.org/attachment.cgi?id=106823&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106823&action=review


r- now, because it isn't the real fix.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:333
> +	       for line in self.incorrectLayoutLines:
> +		   if line.find('flakes') >= 0 or line.find('new passes') >= 0
or line.find('missing results') >= 0:
> +		       result = WARNINGS
> +		   else:
> +		       return FAILURE
>  
>	   if cmd.rc != 0:
>	       return FAILURE

If there are 5 new test, but 0 real failure, then result will 
be WARNINGS, but cmd.rc == 5 will cause return FAILURE.