[webkit-reviews] review denied: [Bug 67785] [Qt][WK2] Make QWebError more friendly to QML. : [Attachment 106750] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 67785: [Qt][WK2] Make QWebError more friendly to QML.
https://bugs.webkit.org/show_bug.cgi?id=67785

Attachment 106750: Patch
https://bugs.webkit.org/attachment.cgi?id=106750&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106750&action=review


> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp:147
> +    QWebError lastError(error);
> +    emit q->loadFailed(&lastError);

Hmmm... lifecycle problems coming. This is a classic by-value object; I wish it
could be passed as a QVariantMap or as a heap-allocated QObject that is
transferred to JS scope. Is there a way to do that in QML? Otherwise what I
suggest something like:
loadFailed() and QWebError* lastError(), saving the last QWebError as a child
object of the view - this way lifecycle is safe.

> Source/WebKit2/UIProcess/API/qt/qmlplugin/plugin.cpp:28
> +#include <QtNetwork/QNetworkReply>

Seems unrelated. Crumbs from a separate patch?

> Source/WebKit2/UIProcess/API/qt/qmlplugin/plugin.cpp:43
> +	   qmlRegisterUncreatableType<QNetworkReply>(uri, 5, 0, "NetworkReply",
QObject::tr("Cannot create separate instance of NetworkReply"));

Ditto.