[webkit-reviews] review denied: [Bug 60430] selectstart is not fired when selection was created by arrow keys : [Attachment 106844] Updated patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Arko Saha <nghq36 at motorola.com>'s
request for review:
Bug 60430: selectstart is not fired when selection was created by arrow keys
https://bugs.webkit.org/show_bug.cgi?id=60430

Attachment 106844: Updated patch
https://bugs.webkit.org/attachment.cgi?id=106844&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106844&action=review


> Source/WebCore/editing/FrameSelection.cpp:825
> +	   VisibleSelection trialVisibleSelection =
trialFrameSelection.selection();
> +	   bool change = shouldChangeSelection(trialVisibleSelection);

Why do we need to make a copy of VisibleSelection here?

> LayoutTests/fast/events/selectstart-by-arrow-keys.html:13
> +div.addEventListener('selectstart', function (event) { selectStartCount++;
});

We also need a test for preventing the default action.

> LayoutTests/fast/events/selectstart-by-arrow-keys.html:58
> +	    document.write('PASS.');

Nit: wrong indentation. Also maybe get rid of . at the end?

> LayoutTests/fast/events/selectstart-by-arrow-keys.html:59
> +    document.writeln('<br />');

Don't think we should use XML-style br.