[webkit-reviews] review granted: [Bug 67763] Crashes in WebCore::InsertNodeBeforeCommand constructor. : [Attachment 106815] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Annie Sullivan
<sullivan at chromium.org>'s request for review:
Bug 67763: Crashes in WebCore::InsertNodeBeforeCommand constructor.
https://bugs.webkit.org/show_bug.cgi?id=67763

Attachment 106815: Patch
https://bugs.webkit.org/attachment.cgi?id=106815&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106815&action=review


Perfect!

>
LayoutTests/editing/inserting/insert-paragraph-selection-outside-contenteditabl
e-expected.txt:1
> + This test ensures that WebKit does not crash when the selection is outside
of the contenteditable area.

You should hide the meter element so that it won't add space in front of
"This".

I'd also like to see this test making sure the DOM is not changed by the
editing command.

> Source/WebCore/ChangeLog:10
> +	   root.

Could you fit "root" in the previous line so that it's easier to read?