[webkit-reviews] review denied: [Bug 40338] display:none element should not retain focus : [Attachment 106741] Updated patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Vineet N Chaudhary
<rgf748 at motorola.com>'s request for review:
Bug 40338: display:none element should not retain focus
https://bugs.webkit.org/show_bug.cgi?id=40338

Attachment 106741: Updated patch
https://bugs.webkit.org/attachment.cgi?id=106741&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106741&action=review


WebKit bug fixes need to come with regression tests. Please create a test and
include it in the patch along with the fix.

> Source/WebCore/dom/Element.cpp:1758
> +    Document* doc = document();

Please don’t use the abbreviation "doc" instead of a word. The preferred way to
write this in WebKit code is:

    Document* document = this->document();