[webkit-reviews] review granted: [Bug 67773] [Qt] Remove the QStyle dependency in Qt's mobile theme : [Attachment 106720] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 8 04:30:26 PDT 2011


Andreas Kling <kling at webkit.org> has granted Pierre Rossi
<pierre.rossi at gmail.com>'s request for review:
Bug 67773: [Qt] Remove the QStyle dependency in Qt's mobile theme
https://bugs.webkit.org/show_bug.cgi?id=67773

Attachment 106720: Patch
https://bugs.webkit.org/attachment.cgi?id=106720&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106720&action=review


r=me with nits.

> Source/WebCore/ChangeLog:6
> +	   GraphicsContext3DQt doesn't actually use QStyleOption

use -> need

> Source/WebCore/ChangeLog:10
> +	   No new tests as there should be no functionnal change.

functionnal -> functional


More information about the webkit-reviews mailing list