[webkit-reviews] review canceled: [Bug 67612] Protect against incorrect Element::fast*Attribute() usage. : [Attachment 106406] Proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 8 04:12:59 PDT 2011


Andreas Kling <kling at webkit.org> has canceled Andreas Kling
<kling at webkit.org>'s request for review:
Bug 67612: Protect against incorrect Element::fast*Attribute() usage.
https://bugs.webkit.org/show_bug.cgi?id=67612

Attachment 106406: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=106406&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
As Darin pointed out, adding a special getter for the class attribute is
probably not worth the added complexity just to get this optimization.
This new patch gets rid of Element::getClassAttribute() and switches
fastGetAttribute(classAttr) to getAttribute(classAttr) instead.
Also added a missing export of fastAttributeLookupAllowed() to fix the
mac/debug build.


More information about the webkit-reviews mailing list