[webkit-reviews] review denied: [Bug 67643] [Chromium] Add localizedDescription to WebURLError : [Attachment 106418] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 8 00:12:19 PDT 2011
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Martin Kosiba
<mkosiba at chromium.org>'s request for review:
Bug 67643: [Chromium] Add localizedDescription to WebURLError
https://bugs.webkit.org/show_bug.cgi?id=67643
Attachment 106418: proposed fix
https://bugs.webkit.org/attachment.cgi?id=106418&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106418&action=review
> Source/WebKit/chromium/src/WebURLError.cpp:56
> + localizedDescription = error.localizedDescription();
what about when we copy a WebURLError to a ResourceError? don't you want to
copy this field then too?
otherwise copying a ResourceError to a WebURLError to a ResourceError will be a
lossy operation.
can you say more about why you need this information plumbed through here?
More information about the webkit-reviews
mailing list